Avoid exploring TyperState creations #3077
Conversation
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3077 to see the changes. Benchmarks is based on merge(s) with master |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
performance test failed: [check /data/workspace/bench/logs/pull-3077-09-06-13.56.out for more information] |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
performance test failed: [check /data/workspace/bench/logs/pull-3077-09-06-14.02.out for more information] |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3077 to see the changes. Benchmarks is based on merge(s) with master |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3077 to see the changes. Benchmarks is based on merge(s) with master |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3077 to see the changes. Benchmarks is based on merge(s) with master |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
odersky
force-pushed
the
optimize-context-1
branch
from
f7d730d to
8df17e0
Compare
|
test performance please |
|
performance test scheduled: 1 job(s) in queue. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3077 to see the changes. Benchmarks is based on merge(s) with master |
Dotty bootstrap (from dotc directory) has 5924910 context creations. This commit brings that number down to 4307795. It also reduces the number of TyperStates created from 2'059'126 to 308'732.
Have just one class instead of two. This will be important for inlining the `test` method. Also, fix test method - it needs to create a new StoreReporter.
odersky
force-pushed
the
optimize-context-1
branch
from
8df17e0 to
dfff891
Compare
|
Despite inconclusive performance data I think this is a net win. It strongly reduces total allocations and the code ends up simpler than before. |
Dotty bootstrap (from dotc directory) has 5924910 context creations.
This commit brings that number down to 4307795. It also reduces the
number of TyperStates created from 2'059'126 to 308'732.